Use real root filename as theoretical root yaml file #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2024
lobocv
commented
Aug 19, 2024
added 2 commits
August 28, 2024 09:04
…name of the root spec (often openapi.yaml). This fixes issues with resolving references in rules such as unsused-components.
lobocv
force-pushed
the
fix-theoretical-root
branch
from
e3e9a67
to
bc413a1
Compare
…en the spec's root does not exist on the filesystem (either read from remote URL or []byte)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 164 164
Lines 16586 16627 +41
=======================================
+ Hits 16526 16567 +41
Misses 55 55
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lobocv
commented
Aug 28, 2024
lobocv
force-pushed
the
fix-theoretical-root
branch
from
a6c319d
to
e4a49c0
Compare
daveshanley
requested changes
Aug 28, 2024
daveshanley
reviewed
Aug 28, 2024
daveshanley
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using "root.yaml" as a theoretical root, use the real filename of the root spec (often openapi.yaml). This fixes issues with resolving references in rules such as unused-components.